Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stop after driving a spline #172

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Do not stop after driving a spline #172

merged 9 commits into from
Aug 14, 2024

Conversation

pascalzauberzeug
Copy link
Contributor

Our robot needs to drive continuously between two GNSS coordinates while adjusting its heading. For each segment we use drive_spline, but it stops after completing the spline drive.
This PR adds a parameter for not stopping at the end stop_at_end and does some refactoring in the Driver class

@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Aug 13, 2024
@pascalzauberzeug pascalzauberzeug added this to the 0.14.0 milestone Aug 13, 2024
@falkoschindler
Copy link
Contributor

@pascalzauberzeug Before looking into the details of this PR, can you please

  • update the docstrings according to PEP 257 (indicative, no new line after the opening triple quotes),
  • use reSt style (see calibration.py for some good examples), and
  • fix examples/hello_bot/main.py which is still using drive_square?

Thanks!

By the way, we should probably add a note about docstrings in CONTRIBUTING.md to avoid such back and forth between styles.

@pascalzauberzeug
Copy link
Contributor Author

@falkoschindler Sure, I will look into it. To admit, copilot wrote those docstrings 😆

@falkoschindler falkoschindler merged commit 1594273 into main Aug 14, 2024
4 checks passed
@falkoschindler falkoschindler deleted the dont_stop branch August 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants