Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bitrate parameter to RTSP cameras #184

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Conversation

NiklasNeugebauer
Copy link
Contributor

Adds the bitrate as a parameter. The control was already supported through the jovision interface.

Aditionally, I have made some adjustments to the interface:

  • username/ password in the header turned out not to be necessary
  • some type hints were missing
  • there was an extra channelid in the param dict
  • the values to be set are easy to set as an incorrect type without noticing so I added a backup int cast

Copy link
Contributor

@denniswittich denniswittich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests with jovision camera successful.

@denniswittich denniswittich merged commit 8693704 into main Sep 3, 2024
5 checks passed
@denniswittich denniswittich deleted the rtsp-bitrate-control branch September 3, 2024 16:27
@falkoschindler falkoschindler added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants