made step_size of Carrot.move() independent from the Spline length #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this optimizes the behavior of move() for very long splines and avoids that the Driver aborts at 99% because of the former stepsize of 1%
falkoschindler
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Thanks a lot for this pull request, @AndyPermaRobotics!
I just did some minor changes and added a pytest to cover the case of driving long splines. It indeed succeeds when using the new step size. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this optimizes the behavior of move() for very long splines and avoids that the Driver aborts at 99% because of the former stepsize of 1%