-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify camera providers #25
Conversation
remove prune_images call
We came up with the following class hierarchy for structuring cameras and camera providers in our projects: RoSysCameraProvider CalibratedCamera [mixin] Camera Project 1FolderCameraProvider GalaxyCameraProvider CameraScanner Project 2WifiCamera(CalibratedCamera, Camera) |
# Conflicts: # poetry.lock
Upon further review and if I understand asyncio correctly, the locking mechanism will not be necessary. In fact, the old problem should also be fixable without a lock by moving the check for the existence of the device inside |
This PR tries to unify different camera provider classes:
active
flag has a different meaning. We will rename it tois_connected
and let it represent the device state, not whether the user wants it to be active.enable()
/disable()
methods and anis_enabled
property to allow the user to enable/disable the capturing process.MultiCameraProvider
andCombiningCameraProvider
are doing the same. We can remove the latter.CAMERA_ADDED
event should be emitted more consistently.