Add !default suffix to overridable variables
#19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the common behaviour using Sass. This way a developer can declare other $md-font-path, $md-css-prefix and $md-border-color without having to touch the library files. The default values are used only if no global variable with the same name already exists.
|
Fixed in 2.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this push request, developer can redeclare $md-font-path, $md-css-prefix and $md-border-color in their own SCSS files before they import material-design-iconic-font. So this is now easy to leave the library files untouched (which will allow for easier/automated update of the dependencies).
The default values are used only if no global variable with the same name already exists.