Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support map #40

Merged
merged 11 commits into from
Apr 2, 2024
Merged

Feat support map #40

merged 11 commits into from
Apr 2, 2024

Conversation

HugoWw
Copy link
Contributor

@HugoWw HugoWw commented Jan 6, 2024

Supports map type resolution and has been approved by TestDefine

@HugoWw HugoWw closed this Mar 11, 2024
@zc2638
Copy link
Owner

zc2638 commented Mar 11, 2024

Sorry, I have been busy with another project recently and forgot to follow it.
I will take time to take a look at it in the afternoon.
I am very sorry.
@HugoWw

reflect.go Outdated Show resolved Hide resolved
reflect.go Outdated Show resolved Hide resolved
reflect.go Outdated Show resolved Hide resolved
@zc2638 zc2638 reopened this Mar 14, 2024
@HugoWw HugoWw closed this Apr 1, 2024
@HugoWw
Copy link
Contributor Author

HugoWw commented Apr 1, 2024

Step back from the pr process

@HugoWw HugoWw reopened this Apr 1, 2024
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
reflect.go Show resolved Hide resolved
reflect.go Outdated Show resolved Hide resolved
reflect.go Show resolved Hide resolved
@zc2638
Copy link
Owner

zc2638 commented Apr 2, 2024

@HugoWw Finally, need to solve the unit-test error.

@HugoWw
Copy link
Contributor Author

HugoWw commented Apr 2, 2024

@HugoWw Finally, need to solve the unit-test error.

done!

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 83.46457% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 89.73%. Comparing base (ca43ef8) to head (461cd28).

Files Patch % Lines
reflect.go 83.46% 16 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   90.74%   89.73%   -1.01%     
==========================================
  Files          11       11              
  Lines         821      945     +124     
==========================================
+ Hits          745      848     +103     
- Misses         69       85      +16     
- Partials        7       12       +5     
Flag Coverage Δ
all 89.73% <83.46%> (-1.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zc2638
Copy link
Owner

zc2638 commented Apr 2, 2024

Thanks for your contribution, I will release it in 1.6.0.

@zc2638 zc2638 merged commit 35fc1f3 into zc2638:main Apr 2, 2024
2 of 4 checks passed
@HugoWw
Copy link
Contributor Author

HugoWw commented Apr 2, 2024

Thanks for your contribution, I will release it in 1.6.0.

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants