Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings for zcash_client_sqlite. #363

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

nuttycom
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #363 (88fbd9f) into master (a80fd59) will not change coverage.
The diff coverage is n/a.

❗ Current head 88fbd9f differs from pull request most recent head 78f6432. Consider uploading reports for the commit 78f6432 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files          70       70           
  Lines        7149     7149           
=======================================
  Hits         4636     4636           
  Misses       2513     2513           
Impacted Files Coverage Δ
zcash_client_sqlite/src/chain.rs 97.56% <ø> (ø)
zcash_client_sqlite/src/error.rs 15.15% <ø> (ø)
zcash_client_sqlite/src/lib.rs 54.61% <ø> (ø)
zcash_client_sqlite/src/wallet.rs 79.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80fd59...78f6432. Read the comment docs.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK mod comments

zcash_client_sqlite/src/lib.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
@str4d str4d merged commit 60ffeb7 into zcash:master Mar 26, 2021
@nuttycom nuttycom deleted the doc/zcash_client_sqlite branch March 26, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants