Skip to content

Commit

Permalink
Merge pull request #916 from daira/zip-244-clarification
Browse files Browse the repository at this point in the history
ZIP 244: clarify that shielded inputs can't just sign the txid if there are transparent inputs
  • Loading branch information
str4d authored Oct 16, 2024
2 parents a59deab + 4fb6bd7 commit e56a718
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion rendered/zip-0244.html
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
</section>
</section>
<section id="signature-digest"><h4><span class="section-heading">Signature Digest</span><span class="section-anchor"> <a rel="bookmark" href="#signature-digest"><img width="24" height="24" class="section-anchor" src="assets/images/section-anchor.png" alt=""></a></span></h4>
<p>A new per-input transaction digest algorithm is defined that constructs a hash that may be signed by a transaction creator to commit to the effects of the transaction. A signature digest is produced for each transparent input, each Sapling input, and each Orchard action. For transparent inputs, this follows closely the algorithms from ZIP 143 <a id="footnote-reference-10" class="footnote_reference" href="#zip-0143">6</a> and ZIP 243 <a id="footnote-reference-11" class="footnote_reference" href="#zip-0243">7</a>. For shielded inputs, this algorithm has the exact same output as the transaction digest algorithm, thus the txid may be signed directly.</p>
<p>A new per-input transaction digest algorithm is defined that constructs a hash that may be signed by a transaction creator to commit to the effects of the transaction. A signature digest is produced for each transparent input, each Sapling input, and each Orchard action. This follows closely the algorithms from ZIP 143 <a id="footnote-reference-10" class="footnote_reference" href="#zip-0143">6</a> and ZIP 243 <a id="footnote-reference-11" class="footnote_reference" href="#zip-0243">7</a>. For transactions without transparent inputs, this algorithm has the exact same output as the transaction digest algorithm, thus the txid may be signed directly.</p>
<p>The overall structure of the hash is as follows; each name referenced here will be described in detail below:</p>
<pre>signature_digest
├── header_digest
Expand Down
6 changes: 3 additions & 3 deletions zips/zip-0244.rst
Original file line number Diff line number Diff line change
Expand Up @@ -453,9 +453,9 @@ Signature Digest
A new per-input transaction digest algorithm is defined that constructs a hash that may be
signed by a transaction creator to commit to the effects of the transaction. A signature
digest is produced for each transparent input, each Sapling input, and each Orchard
action. For transparent inputs, this follows closely the algorithms from ZIP 143 [#zip-0143]_
and ZIP 243 [#zip-0243]_. For shielded inputs, this algorithm has the exact same output
as the transaction digest algorithm, thus the txid may be signed directly.
action. This follows closely the algorithms from ZIP 143 [#zip-0143]_ and ZIP 243 [#zip-0243]_.
For transactions without transparent inputs, this algorithm has the exact same output as
the transaction digest algorithm, thus the txid may be signed directly.

The overall structure of the hash is as follows; each name referenced here will be
described in detail below::
Expand Down

0 comments on commit e56a718

Please sign in to comment.