Fixed dfply documentation on verbs, created longs of those verbs, and improved dflpy import. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously calling "help" command on dfply verbs did not produce any useful documentation. This has been remedied and now will print documentation on the verb as well as inherited pipe methods just like the current other grama verbs do. Another change was in doing so long versions were created of all dfply verbs. Import system in dfply update to reflect this but still needs work. Unit-testing particular to long dfply verbs still needs to be implemented.
Dfply previously was being imported by individual lines for each need verb or tool. Now each file has been udpdated to use the __all__ attribute in order to relative import everything from dfply now on one line in the main __init__.py file
OscarDeGar
changed the title
zdelrosario
requested changes
Jun 21, 2021
| "Pipe-enabled version of {}\n".format(fun.__name__) | ||
| + "Inherited Signature: {}\n".format(signature(fun)) | ||
| + fun.__doc__ | ||
| fun.__doc__ |
There was a problem hiding this comment.
This creates a new issue that we'll have to resolve....
There was a problem hiding this comment.
@OscarDeGar can you open a new Issue to track this? Last thing to fix before moving on....
…l imports of packages
…l imports of packages Typo
Fixed cyclic imports in dfply, unnecessary else & elif statments after returns, and missing is statments for singleton comparison.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 89.80% 98.99% +9.19%
==========================================
Files 80 27 -53
Lines 5393 1787 -3606
==========================================
- Hits 4843 1769 -3074
+ Misses 550 18 -532 Continue to review full report at Codecov.
|
zdelrosario
reviewed
Jun 29, 2021
| import itertools | ||
|
|
||
| import grama as gr | ||
| from grama import add_pipe, pipe |
There was a problem hiding this comment.
I'm curious what best-practices on this are: To import individual methods from the package, or target the source file in the project with that method?
zdelrosario
requested changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #109
Resolves #9