-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dfply documentation on verbs, created longs of those verbs, and improved dflpy import. #110
Conversation
Previously calling "help" command on dfply verbs did not produce any useful documentation. This has been remedied and now will print documentation on the verb as well as inherited pipe methods just like the current other grama verbs do. Another change was in doing so long versions were created of all dfply verbs. Import system in dfply update to reflect this but still needs work. Unit-testing particular to long dfply verbs still needs to be implemented.
Dfply previously was being imported by individual lines for each need verb or tool. Now each file has been udpdated to use the __all__ attribute in order to relative import everything from dfply now on one line in the main __init__.py file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great improvement to the codebase! Requesting some small changes; I'm also going to try to get codecov
working again so we can automatically check coverage....
"Pipe-enabled version of {}\n".format(fun.__name__) | ||
+ "Inherited Signature: {}\n".format(signature(fun)) | ||
+ fun.__doc__ | ||
fun.__doc__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a new issue that we'll have to resolve....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OscarDeGar can you open a new Issue to track this? Last thing to fix before moving on....
…l imports of packages
…l imports of packages Typo
Fixed cyclic imports in dfply, unnecessary else & elif statments after returns, and missing is statments for singleton comparison.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 89.80% 98.99% +9.19%
==========================================
Files 80 27 -53
Lines 5393 1787 -3606
==========================================
- Hits 4843 1769 -3074
+ Misses 550 18 -532 Continue to review full report at Codecov.
|
import itertools | ||
|
||
import grama as gr | ||
from grama import add_pipe, pipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what best-practices on this are: To import individual methods from the package, or target the source file in the project with that method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there! A couple more things to resolve; looks like you still have a couple full-Grama imports running around
Resolves #109
Resolves #9