build(app): add missing Qt components to find_package #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zealdocs#1643. Starting from Qt 6.7.2 it is necessary to list all necessary components for Qt6 rather than deferring them. This commit fixes a build failure when cmake configures a build against Qt >= 6.7.2, where we otherwise see a failure like: ``` [ 14s] CMake Error at /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:259 (message): [ 14s] The Concurrent target is mentioned as a dependency for Registry, but not [ 14s] declared. [ 14s] Call Stack (most recent call first): [ 14s] /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:228 (__qt_internal_walk_libs) [ 14s] /usr/lib64/cmake/Qt6/QtPublicWalkLibsHelpers.cmake:311 (__qt_internal_walk_libs) [ 14s] /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:651 (__qt_internal_collect_all_target_dependencies) [ 14s] /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:774 (_qt_internal_finalize_executable) [ 14s] /usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:590:EVAL:1 (qt6_finalize_target) [ 14s] src/app/CMakeLists.txt:DEFERRED ``` and so on for all missing components.
|
Note — builds here with just |
trollixx
requested changes
Jul 28, 2024
trollixx
changed the title
trollixx
approved these changes
Jul 28, 2024
|
Thanks for the quick merge. I can confirm that it builds with the modified patch on openSUSE as well. |
4 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1643.
Starting from Qt 6.7.2 it is necessary to list all necessary components for Qt6 rather than deferring them. This commit fixes a build failure when cmake configures a build against Qt >= 6.7.2, where we otherwise see a failure like:
and so on for all missing components.