-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when created an excluded file #10890
Comments
Hello! Is this still happening? If so, could you share the exact steps to reproduce the issue? |
Yeah, got it this afternoon Read the issue, you need to create a file that you excluded from the tree |
I cannot reproduce the issue, and it seems very unlikely that this is due to the files being excluded since the crash happens in the text system. Could you share your Zed settings? (mainly font settings and such) |
It is totally related. In fact I added a special name to file_scan_exclusions and tried to create the file and it crashed. "file_scan_exclusions": [
"**/.make-it-crash"
]
|
@williamdes , sounds like you have something else in your settings that makes it panic. As it shows in the backtrace, the crash is related to font rendering, so listening to the previous message and providing your settings, especially
is a way forward. Here's a video with the latest Preview that does not crash for me (albeit the behavior is still not good): |
Thank you for this video. It crashes on my end. zed-crash.mp4 |
Great, now we have to ask you, for the 3rd time in this issue, to provide your settings. |
Gosh, sorry about that 🤦🏻 {
"file_scan_exclusions": [
"**/.gitignore"
]
} The bug does not change |
This comment was marked as off-topic.
This comment was marked as off-topic.
Ohh, I see, sorry for misreading the last comment — so there's something system-related then? I will try to poke at it, but it's quite hard to understand what's not matching the "regular" experience. |
I am using XFCE 4.18 on Debian 12 and did not change font stuff.
Yes, sure, I will test it right away On your video it looked like there is a GUI bug, maybe fix this first and we will see if the crash persists |
There was more than one bug related to the directory creation, and overall the ergonomics required some improvements, so it was a relatively long one: #12620 The fix is coming this Wednesday with Zed 0.139 |
Fixes #10890 * removes `unwrap()` that caused panics for text elements with no text, remaining after edit state is cleared but project entries are not updated, having the fake, "new entry" * improves discoverability of the FS errors during file/directory creation: now those are shown as workspace notifications * stops printing anyhow backtraces in workspace notifications, printing the more readable chain of contexts instead * better indicates when new entries are created as excluded ones Release Notes: - Improve excluded entry creation workflow in the project panel ([10890](#10890))
Thank you for the fix ! |
Check for existing issues
Describe the bug / provide steps to reproduce it
I tried to create a
.gitignore
fileEnvironment
Zed: v1.0.0 (Zed Dev 615de38)
OS: Debian 12
Memory: 62.4 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.No response
The text was updated successfully, but these errors were encountered: