Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering artifacts above diagnostic icons in the status bar #643

Closed
maxbrunsfeld opened this issue Mar 18, 2022 · 0 comments · Fixed by #691
Closed

Rendering artifacts above diagnostic icons in the status bar #643

maxbrunsfeld opened this issue Mar 18, 2022 · 0 comments · Fixed by #691
Labels
defect [core label]

Comments

@maxbrunsfeld
Copy link
Collaborator

Screen Shot 2022-03-18 at 12 47 04 PM

I'm not sure what I did to make these appear. Changing the theme did not affect them. Changing the buffer font size did make them go away.

Is it possible that somewhere, when writing to the sprite atlas, we're accidentally drawing outside of the intended bounds, so that we're getting stray pixels when rendering these SVGs?
@maxbrunsfeld maxbrunsfeld added the defect [core label] label Mar 18, 2022
@as-cii as-cii mentioned this issue Mar 28, 2022
Merged
@jansol jansol mentioned this issue May 27, 2024
Closed
1 task
@apricotbucket28 apricotbucket28 mentioned this issue Aug 5, 2024
Merged
mikayla-maki pushed a commit that referenced this issue Aug 5, 2024
@apricotbucket28
gpui: Align SVG sprites to whole pixels (#15822)
ab1fabe 
Related to #12352 (and old
issue #643)

This fixes visual glitches that could happen when rendering icons on
Linux and Windows (and in the Blade backend)


![image](https://github.com/user-attachments/assets/02646d1d-d35b-48be-89c9-189416510cf2)

![image](https://github.com/user-attachments/assets/ccf99867-25d2-40fb-8735-c540f8cf793a)

![image](https://github.com/user-attachments/assets/8d1124a3-669e-4be5-8b46-5dc2df14a28a)


Release Notes:

- Linux: Fixed visual glitches when rendering icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Snap icon sprites to pixel grid zed-industries/zed
1 participant
@maxbrunsfeld