Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give zed window class #9132

Closed
1 task done
ThatOneCalculator opened this issue Mar 10, 2024 · 3 comments · Fixed by #10909
Closed
1 task done

Give zed window class #9132

ThatOneCalculator opened this issue Mar 10, 2024 · 3 comments · Fixed by #10909
Labels
enhancement [core label] linux

Comments

@ThatOneCalculator
Copy link
Contributor

ThatOneCalculator commented Mar 10, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the feature

On Linux + Wayland, getting the active window information (in this case, with hyprctl activewindow) shows that there's no class or initialClass. Giving it a class of zed would make it far easier to manage.

Window 60e065a26ff0 -> empty project:
	mapped: 1
	hidden: 0
	at: 1846,618
	size: 1572,800
	workspace: 1 (1)
	floating: 0
	monitor: 0
	class: 
	title: empty project
	initialClass: 
	initialTitle: empty project
	pid: 31816
	xwayland: 0
	pinned: 0
	fullscreen: 0
	fullscreenmode: 0
	fakefullscreen: 0
	grouped: 0
	swallowing: 0
	focusHistoryID: 0

Related/parent: #7015
@ThatOneCalculator ThatOneCalculator added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Mar 10, 2024
@Moshyfawn Moshyfawn added linux and removed triage Maintainer needs to classify the issue labels Mar 10, 2024
@bbb651
Copy link
Contributor

bbb651 commented Mar 10, 2024

This can be done with xdg_toplevel::set_app_id on wayland and WM_CLASS on x11rb, currently GPUI apps don't set an app identifier at all (nor an app version) since on macos you get it from the app bundle, so a good place to start is getting it from the application somewhere here, after that it's pretty easy to expose it

@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 11, 2024
@antifallobst
Copy link

Is there already someone working on this? If not, I can look into it.

@Moshyfawn Moshyfawn mentioned this issue Apr 22, 2024
Closed
1 task
@jakobhellermann jakobhellermann mentioned this issue Apr 23, 2024
Merged
mikayla-maki pushed a commit that referenced this issue Apr 29, 2024
@jakobhellermann
Set appid/wmclass for zed window (#10909)
2386ae9 
fixes #9132

By setting the app id, window managers like `sway` can apply custom
configuration like `for_window [app_id="zed"] floating enable`.
Tested using `wlprop`/`hyprctl activewindow` for wayland, `xprop` for
x11.


Release Notes:

- Zed now sets the window app id / class, which can be used e.g. in
window managers like `sway`/`i3` to define custom rules
@ThatOneCalculator
Copy link
Contributor Author

🎉 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set appid/wmclass for zed window jakobhellermann/zed
5 participants
@Moshyfawn @JosephTLyons @ThatOneCalculator @bbb651 @antifallobst