Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync maximized state from top-level configure event for a wayland window #11003

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

aki237
Copy link
Contributor

@aki237 aki237 commented Apr 25, 2024

  • Otherwise is_maximized always returns true

Release Notes:

  • Fixed maximized state. Tested with a dummy maximize/restore button with the zoom() (not implemented yet). Without the right maximized, in toggle zoom function is not possible to call set_maximized() or unset_maximized().
    fn zoom(&self) {
      if self.is_maximized() {
        self.borrow_mut().toplevel.unset_maximized();
      } else {
        self.borrow_mut().toplevel.set_maximized();
      }
    }

Copy link

cla-bot bot commented Apr 25, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @aki237 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@aki237
Copy link
Contributor Author

aki237 commented Apr 25, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 25, 2024
Copy link

cla-bot bot commented Apr 25, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mikayla-maki mikayla-maki self-assigned this Apr 25, 2024
@aki237 aki237 force-pushed the fix-linux-wayland-state-sync branch from d3ceec4 to 240b4ea Compare April 25, 2024 22:22
@aki237
Copy link
Contributor Author

aki237 commented Apr 25, 2024

Sorry for the commits, I was working on a PoC for draggable wayland windows, accidently pushed it to this branch.

@mikayla-maki mikayla-maki merged commit 7bd18fa into zed-industries:main Apr 26, 2024
8 checks passed
@mikayla-maki
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants