Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yss operation support for vim surrounds: #11084

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

weartist
Copy link
Contributor

The Motion::CurrentLine operation will contain the newline of the current line, so we need to deal with this edge case

Release Notes:

  • N/A

The Motion::CurrentLine operation will contain the newline of the current line, so we need to deal with this edge case
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 27, 2024
@ConradIrwin ConradIrwin self-assigned this Apr 30, 2024
@ConradIrwin
Copy link
Member

Thanks!

@ConradIrwin ConradIrwin merged commit 4fad96b into zed-industries:main Apr 30, 2024
8 checks passed
@0x2CA
Copy link
Contributor

0x2CA commented Apr 30, 2024

There seems to be a problem.

2024-04-30.10.02.51.mov
2024-04-30.10.03.18.mov

@weartist
Copy link
Contributor Author

There seems to be a problem.

2024-04-30.10.02.51.mov
2024-04-30.10.03.18.mov

I forgot about the case where the beginning was empty XD

ConradIrwin added a commit that referenced this pull request May 1, 2024
For #11084 In the case of an indentation in front of the current line,
it may also be necessary to deal with the start point of the selected
range


Release Notes:


- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants