Add support for detecting tests in source files, and implement it for Rust #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore live updating language queries
Co-authored-by: Mikayla <mikayla@zed.dev>
- With OG code actions, check line number of active actions menu before deciding whether to use 'selected' color for code actions bolt (fixes: wrong color of bolt when both test indicator and code action bolt is visible) - Fixed position of code actions menu when clicking on not-yet-selected line (it is currently attached to current line). - Fixed usage of cmd-. with code actions (we did not wire through row number properly prior to that and tasks didn't show up when opening the context menu through keybind. - Wire through selected status for task indicator.
Additionally, fix a bug where the task menu would pick up code actions from currently focused line, even when it may not be applicable to that task menu.
cla-bot
bot
added
the
cla-signed
4 tasks
|
I believe all that's left before we land this is support for tag rebinding (allowing users to bind given tag to a different task); I plan to merge this PR as is optimistically on Sunday to have it in Nightly by Monday and then move with implementing task rebinding. Also, Mikayla remarked that we should not be showing test indicators in remote projects. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work from #10873
Release Notes: