linux/x11: Ignore bounds.origin on resize event #12604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #11236 by ignoring the `bounds.origin` values when the window is only being resized. The cause for the issue was that the `ConfigureNotify` event would contain "wrong" values when the window was being resized (by dragging a corner). In my case it would *always* contain x:14/y:49, which is I think maps to the origin of the top bar in GNOME. We would then persist these wrong values when serializing the workspace. On restart, we'd use these values and end up with the window decorations in the wrong place. What I still don't know: 1. What exactly the 14/49 map to, because it's not the origin of the top bar in GNOME. I also tried the X11 TranslateCoordinates call but couldn't get meaningful results back (even taking scale factor into account). 2. Why the window decorations end up looking wrong vs. the window being in the first place. But if you look at my screenshot in #11236, it looks like the decorations are off exactly by 14/49px. That being said, I think the solution here is a good one for now: we don't do an additional X11 call and when we're resizing, we're not interested in the origin changing.
cla-bot
bot
added
the
cla-signed
|
Works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11236 by ignoring the
bounds.originvalues when the window is only being resized.The cause for the issue was that the
ConfigureNotifyevent would contain "wrong" values when the window was being resized (by dragging a corner).In my case it would always contain x:14/y:49, which is I think might map to the origin of the top bar in GNOME.
We would then persist these wrong values when serializing the workspace. On restart, we'd use these values and end up with the window decorations in the wrong place.
What I still don't know:
That being said, I think the solution here is a good one for now: we don't do an additional X11 call and when we're resizing, we're not interested in the origin changing.
Release Notes:
Proof:
Screencast.from.2024-06-03.15-08-36.webm