Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum version of xdg_wm_base wayland protocol to fix WSLg #14511

Closed
wants to merge 1 commit into from

Conversation

nsaslavsky
Copy link

I searched code base and didn't find any usages of the xdg_wm_base that were needed version 2+.

In case someone else runs into something similar wayland-info was helpful to know what protocols are supported by WSLg.

Release Notes:

  • Fixed running on WSLg (#14126).

Copy link

cla-bot bot commented Jul 15, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @nsaslavsky on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@nsaslavsky nsaslavsky changed the title change minimum version of xdg_wm_base wayland protocol to fix running… change minimum version of xdg_wm_base wayland protocol to fix WSLg Jul 15, 2024
@maxdeviant maxdeviant changed the title change minimum version of xdg_wm_base wayland protocol to fix WSLg Change minimum version of xdg_wm_base wayland protocol to fix WSLg Jul 15, 2024
@nsaslavsky
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 15, 2024
Copy link

cla-bot bot commented Jul 15, 2024

The cla-bot has been summoned, and re-checked this pull request!

@apricotbucket28
Copy link
Contributor

apricotbucket28 commented Jul 15, 2024

I searched code base and didn't find any usages of the xdg_wm_base that were needed version 2+.

Zed relies on version 2 because it needs tiling information to work properly.
Also, version 5 is optionally requested for the WmCapabilities event.

Gnome, KDE and Sway have supported this protocol for years, so it seems like WSL's Wayland implementation is highly incomplete? Also, doesn't it make more sense to run the native Zed version for Windows?

Edit: Sorry if what I said sounds confrontational, but I'm worried about making changes only to support WSLg when:

  • These are protocols that should be widely available (and have been implemented for years in all compositors)
  • There's already a native version of Zed for Windows

Hope this isn't taken the wrong way 🙂

@nsaslavsky
Copy link
Author

nsaslavsky commented Jul 15, 2024

I'll close this then, doesn't bother me at all. I was just curious if it could be made to work easily. I don't know much about it, but WSLg appears to be using libweston and Weston 13 supposed supports version 5 of the protocol (https://wayland.app/protocols/xdg-shell#compositor-support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants