Use char level diff for Rewrap action for cursor preservation + not reinserting all text #20368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
force-pushed
the
rewrap-preserve-cursors
branch
2 times, most recently
from
d4bba83
to
b7b9b43
Compare
…einserting all text Line level diff is still used for vim rewrap because it causes the cursor behavior to match vim. It would be better to use char-level diff and explicitly implement the vim cursor behavior
mgsloan
force-pushed
the
rewrap-preserve-cursors
branch
from
b7b9b43
to
f7e9ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18896
Release Notes:
editor::Rewrapnow preserves cursors and only inserts whitespace by using character-level diff instead of line-level diff.