Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item closing overtly triggering save dialogues #21374

Merged
merged 11 commits into from
Nov 30, 2024
Merged

Fix item closing overtly triggering save dialogues #21374

merged 11 commits into from
Nov 30, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Nov 30, 2024 •
edited by notpeter
Loading

Closes #12029

Allows to introspect project items inside items more deeply, checking them for being dirty.
For that:

  • renames project::Item into project::ProjectItem
  • adds an is_dirty(&self) -> bool method to the renamed trait
  • changes the closing logic to only care about dirty project items when checking for save prompts conditions
  • save prompts are raised only if the item is singleton without a project path; or if the item has dirty project items that are not open elsewhere

Release Notes:

  • Fixed item closing overtly triggering save dialogues

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 30, 2024
@SomeoneToIgnore SomeoneToIgnore merged commit 28849dd into main Nov 30, 2024
12 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/rework-save-prompts branch November 30, 2024 23:48
@notpeter notpeter changed the title Fix item closing overly triggering save dialogues Fix item closing overtly triggering save dialogues Dec 2, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Dec 14, 2024
Merged
SomeoneToIgnore added a commit that referenced this pull request Dec 14, 2024
@SomeoneToIgnore
Fix terminal pane tabs arrangement and closing (#22013)
9daa426 
* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of #21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 14, 2024
@SomeoneToIgnore
Fix terminal pane tabs arrangement and closing (#22013)
eae4fa9 
* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of #21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Dec 14, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 14, 2024
@SomeoneToIgnore
Fix terminal pane tabs arrangement and closing (#22013)
7f4b0f7 
* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of #21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Dec 14, 2024
Merged
SomeoneToIgnore added a commit that referenced this pull request Dec 14, 2024
@gcp-cherry-pick-bot @SomeoneToIgnore
Fix terminal pane tabs arrangement and closing (cherry-pick #22013) (#…
ee38693 
…22017)

Cherry-picked Fix terminal pane tabs arrangement and closing (#22013)

* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of #21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
SomeoneToIgnore added a commit that referenced this pull request Dec 14, 2024
@gcp-cherry-pick-bot @SomeoneToIgnore
Fix terminal pane tabs arrangement and closing (cherry-pick #22013) (#…
e652ce8 
…22016)

Cherry-picked Fix terminal pane tabs arrangement and closing (#22013)

* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of #21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
lino-levan pushed a commit to the-code-editor-company/editor that referenced this pull request Dec 16, 2024
@SomeoneToIgnore @lino-levan
Fix terminal pane tabs arrangement and closing (zed-industries#22013)
88e1265 
* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of zed-industries#21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
zed-industries#21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"This buffer contains unsaved edits" dialogue in Search project files.
1 participant
@SomeoneToIgnore