Impl drag-drop action for Windows #8959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mikayla-maki
requested changes
Mar 6, 2024
| let dragdrop_handler = { | ||
| let inner = context.inner.as_ref().unwrap(); | ||
| let handler = WindowsDragDropHandler(Rc::clone(inner)); | ||
| let dragdrop_handler: IDropTarget = handler.into(); |
| @@ -926,3 +1084,6 @@ unsafe fn set_window_long(hwnd: HWND, nindex: WINDOW_LONG_PTR_INDEX, dwnewlong: | |||
| SetWindowLongW(hwnd, nindex, dwnewlong as i32) as isize | |||
| } | |||
| } | |||
|
|
|||
| const DRAGDROP_GET_COUNT: u32 = 0xFFFFFFFF; | |||
There was a problem hiding this comment.
Where does this constant come from?
There was a problem hiding this comment.
Sorry for the delay, it was 2 am when I submitted this PR.
By Microsoft:
If the value of this parameter is 0xFFFFFFFF, DragQueryFile returns a count of the files dropped.
|
Looks great! If you could resolve some naming and comment issues + get the PR to passing CI and mergable, we can get this in :) |
|
The spelling check complains about |
|
You could suppress this warning as documented here |
the-jasoney
reviewed
Mar 7, 2024
mikayla-maki
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a part of #8809
default.mp4
Release Notes: