Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seventh iteration of the Court pallet #248

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Seventh iteration of the Court pallet #248

merged 1 commit into from
Sep 4, 2021

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 1, 2021

cc #200
depends on #244

Implements all features of #200 regarding market resolution.

@c410-f3r c410-f3r added the s:review-needed The pull request requires reviews label Aug 2, 2021
This was referenced Aug 10, 2021
@c410-f3r c410-f3r force-pushed the caio-c7 branch 2 times, most recently from ae87e1f to 538564a Compare August 19, 2021 17:39
@c410-f3r
Copy link
Contributor Author

Rebased

zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/lib.rs Outdated Show resolved Hide resolved
zrml/court/src/tests.rs Show resolved Hide resolved
@c410-f3r
Copy link
Contributor Author

Thank you very much for the review @sea212

Sorry I said that all features were implemented but in reality some important things were unfortunately left behind

Copy link
Member

@lsaether lsaether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@lsaether lsaether added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Sep 3, 2021
@c410-f3r c410-f3r closed this Sep 4, 2021
@c410-f3r c410-f3r reopened this Sep 4, 2021
@c410-f3r c410-f3r merged commit 1cf0c62 into main Sep 4, 2021
@c410-f3r c410-f3r deleted the caio-c7 branch September 9, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants