Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BS to Rococo and Zeitgeist to Polkadot #992

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Move BS to Rococo and Zeitgeist to Polkadot #992

merged 5 commits into from
Apr 3, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Mar 21, 2023

  • Adjust chainspecs and clients

  • Bump runtime version and remove migrations

  • Use DOT in Zeitgeist XCM integration tests

  • Use Rococo in Battery Station XCM tests

@sea212
Prepare chainspec and client for Polkadot parachain (#989)
9b3a865 
* Adjust chainspecs and clients

* More adjustment in client,chainspec and runtime

* Bump runtime version and remove migrations

* Use DOT in Zeitgeist XCM integration tests

* Use Rococo in Battery Station XCM tests

* Bump battery station spec_version

* Update lib.rs
@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Mar 21, 2023
@sea212 sea212 self-assigned this Mar 21, 2023
@sea212 sea212 added this to the v0.3.9 milestone Mar 21, 2023
@sea212 sea212 mentioned this pull request Mar 21, 2023
Closed
@sea212 sea212 changed the title Prepare chainspec and client for Polkadot parachain (#989) Move BS to Rococo and Zeitgeist to Polkadot Mar 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #992 (11da23b) into main (1f7ea61) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   94.39%   94.41%   +0.01%     
==========================================
  Files          93       93              
  Lines       21060    21056       -4     
==========================================
  Hits        19880    19880              
+ Misses       1180     1176       -4
Flag Coverage Δ
tests 94.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codecov-commenter
Copy link

Codecov Report

Merging #992 (0218036) into main (1f7ea61) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   94.39%   94.41%   +0.01%     
==========================================
  Files          93       93              
  Lines       21060    21056       -4     
==========================================
  Hits        19880    19880              
+ Misses       1180     1176       -4
Flag Coverage Δ
tests 94.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Mar 23, 2023
@sea212
Copy link
Member Author

sea212 commented Mar 31, 2023

This PR just merges the new Polkadot configuration from the branch release-v0.3.8-polkadot, that already was improved, into main. The only new changes are the merge of main into the branch and formatting, see 9b3a865...release-v0.3.8-polkadot

Chralt98
Chralt98 reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

runtime/common/src/lib.rs Show resolved Hide resolved
Chralt98
Chralt98 previously approved these changes Mar 31, 2023
View reviewed changes
maltekliemann
maltekliemann reviewed Mar 31, 2023
View reviewed changes
runtime/battery-station/Cargo.toml Outdated
@@ -148,7 +148,7 @@ parachain = [

# XCM

"kusama-runtime",
"rococo-runtime",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be ordered lexicographically, but "rococo-runtime" is not sorted in correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

67906fc

runtime/battery-station/Cargo.toml Show resolved Hide resolved
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Apr 3, 2023
@sea212 sea212 merged commit 6a5dae2 into main Apr 3, 2023
@sea212 sea212 deleted the release-v0.3.8-polkadot branch April 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltekliemann maltekliemann maltekliemann approved these changes

@Chralt98 Chralt98 Chralt98 approved these changes

Assignees

@sea212 sea212

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sea212 @codecov-commenter @Chralt98 @maltekliemann