Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable asm-processor for progress calculation #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yanis42
Copy link
Collaborator

@Yanis42 Yanis42 commented Sep 21, 2024

ported from oot-gc

Yanis42 and others added 2 commits September 21, 2024 17:06
Co-authored-by: encounter <549122+encounter@users.noreply.github.com>
Co-authored-by: cadmic <146315916+cadmic@users.noreply.github.com>
@cadmic
Copy link
Collaborator

cadmic commented Sep 21, 2024

CI is still failing, but I don't think it's too important rn since we can't use asm-processor anyway

@Yanis42
Copy link
Collaborator Author

Yanis42 commented Sep 21, 2024

yeah I noticed that but I'm not sure how to fix it, it fails because of this: build/oot-j/oot-vc.dol: FAILED btw

@cadmic
Copy link
Collaborator

cadmic commented Sep 21, 2024

--non-matching is supposed to disable the checksum check so maybe that needs to be ported over too?

@Yanis42
Copy link
Collaborator Author

Yanis42 commented Sep 21, 2024

I'm confused, when I build with --non-matching myself it doesn't do the checksum check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants