Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU offset comments #59

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix CPU offset comments #59

merged 1 commit into from
Oct 5, 2024
+39 −58

Conversation

cadmic
Copy link
Collaborator

@cadmic cadmic commented Oct 5, 2024

I'm also not convinced about alarmRetrace so I replaced it with more unks

Yanis42
Yanis42 approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@Yanis42 Yanis42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alarmRetrace thing is odd because of the gamecube version but maybe it was just changed? idk, that can be figured out later

edit: nvm it's not used yet apparently lol idk why I thought that

@cadmic cadmic merged commit bb46ead into zeldaret:main Oct 5, 2024
2 checks passed
@cadmic cadmic deleted the cpu-offset-comments branch October 5, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yanis42 Yanis42 Yanis42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadmic @Yanis42