Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session_name to layouts #611

Closed
a-kenji opened this issue Jul 9, 2021 · 0 comments · Fixed by #789
Closed

Add session_name to layouts #611

a-kenji opened this issue Jul 9, 2021 · 0 comments · Fixed by #789
Labels
good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed layout issues related to the layout system

Comments

@a-kenji
Copy link
Contributor

a-kenji commented Jul 9, 2021

Add the ability to specify an optional session name to the layout,
make it overridable by the config flags.
@a-kenji a-kenji added the layout issues related to the layout system label Jul 9, 2021
@a-kenji a-kenji changed the title Add session_name to the layout Add session_name to layouts Jul 9, 2021
@imsnif imsnif added good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed labels Sep 25, 2021
@jaeheonji jaeheonji mentioned this issue Oct 15, 2021
Merged
a-kenji pushed a commit that referenced this issue Nov 8, 2021
@jaeheonji
feat: add initial session name to layout template (#789)
4838f0b 
* feat: add session configuration to layout template

WIP: prototyping for issue #611

* test(layout): add session name

* feat(layout): add cond flow to check session name

* feat(layout): update session

* feat: add function to attach a session

* fix(layout): update feedback

* attach option only works when layout template exists.

* feat(layout): add conditional for session-layout

* update default attach value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed layout issues related to the layout system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add initial session name to layout template
2 participants
@imsnif @a-kenji