Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default.yaml: Reorder key bindings #1078

Closed

Conversation

har7an
Copy link
Contributor

@har7an har7an commented Feb 21, 2022

to reflect the order in which they appear in the UI and add some spacing
to visually group related items.

I hope I didn't lose entries on the way...
I also reordered some of the keybindings due to consistency.

@har7an
Copy link
Contributor Author

har7an commented Feb 21, 2022

Oh darn, I should've rebased before I started working on this... 😂

@har7an har7an force-pushed the feature/sort-keybindings-in-config branch from e5fa95a to aa8e7be Compare February 21, 2022 20:00
@har7an
Copy link
Contributor Author

har7an commented Feb 21, 2022

Interestingly I can't seem to activate the tmux mode from #1073... Is this expected?

to reflect the order in which they appear in the UI and add some spacing
to visually group related items.
@imsnif
Copy link
Member

imsnif commented Feb 24, 2022

Hey @har7an - I think not being able to switch to tmux mode is caused because Zellij is using an old configuration (for example in your ~/.config/zellij folder). This might also be the case with your installed Zellij version, the release notes of 0.25.0 have an "upgrading" section with more info on how to fix this.

About this PR - while I appreciate the work and think this is definitely better - I'm a little concerned about introducing large diffs to people's already existing configs. We're about to make a very large change to our configuration - moving everything from YAML to KDL. Maybe you can incorporate this change as part of those efforts? #1036

@a-kenji
Copy link
Contributor

a-kenji commented Feb 24, 2022

I think not being able to switch to tmux mode is caused because Zellij is using an old configuration (for example in your ~/.config/zellij folder).

Just a small addition @har7an , this is not just because zellij is using an old configuration, but this is most likely because you configured zellij to unbind every single default keybinding with:

keybinds:
    unbind: true

@har7an
Copy link
Contributor Author

har7an commented Feb 25, 2022

We're about to make a very large change to our configuration - moving everything from YAML to KDL

Yes, I've already heard from kenji. I don't mean to steal anyones show, but as I understand it KDL is another markup language, right? How exactly is it superior to YAML? Because I believe that merely adding new sections for general keybindings for all modes would be possible in YAML as well, or not?

Maybe you can incorporate this change as part of those efforts?

Well if the author of #1036 is fine with other people dropping commits into his branch, I can surely look into it. :)

@har7an
Copy link
Contributor Author

har7an commented Feb 25, 2022

Just a small addition @har7an , this is not just because zellij is using an old configuration, but this is most likely because you configured zellij to unbind every single default keybinding with:

Good point, I admit... Thanks!

@imsnif
Copy link
Member

imsnif commented Sep 9, 2022

Hey, @har7an - I'm pretty close to moving us to KDL and so I think I'm going to close this one for now.

@imsnif imsnif closed this Sep 9, 2022
@har7an har7an deleted the feature/sort-keybindings-in-config branch October 23, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants