-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default.yaml: Reorder key bindings #1078
Conversation
Oh darn, I should've rebased before I started working on this... 😂 |
e5fa95a
to
aa8e7be
Compare
Interestingly I can't seem to activate the tmux mode from #1073... Is this expected? |
to reflect the order in which they appear in the UI and add some spacing to visually group related items.
aa8e7be
to
30cbaf5
Compare
Hey @har7an - I think not being able to switch to tmux mode is caused because Zellij is using an old configuration (for example in your ~/.config/zellij folder). This might also be the case with your installed Zellij version, the release notes of About this PR - while I appreciate the work and think this is definitely better - I'm a little concerned about introducing large diffs to people's already existing configs. We're about to make a very large change to our configuration - moving everything from YAML to KDL. Maybe you can incorporate this change as part of those efforts? #1036 |
Just a small addition @har7an , this is not just because zellij is using an old configuration, but this is most likely because you configured zellij to unbind every single default keybinding with:
|
Yes, I've already heard from kenji. I don't mean to steal anyones show, but as I understand it KDL is another markup language, right? How exactly is it superior to YAML? Because I believe that merely adding new sections for general keybindings for all modes would be possible in YAML as well, or not?
Well if the author of #1036 is fine with other people dropping commits into his branch, I can surely look into it. :) |
Hey, @har7an - I'm pretty close to moving us to KDL and so I think I'm going to close this one for now. |
to reflect the order in which they appear in the UI and add some spacing
to visually group related items.
I hope I didn't lose entries on the way...
I also reordered some of the keybindings due to consistency.