-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2040): rudimentary background session creation #2049
Conversation
I haven't taken a lot of time to understand the problem, but your description sounds like this could be it. Check out the "Normal" and "Alternative" screen buffers in these docs. I think what may be happening is you're entering the "Alternative" screen buffer and not switching back to "normal" before exiting, so you'll need to keep Zellij from outputting those sequences when using the If this is the case, you may have also noticed that either clicking or scrolling produces strange characters in your command prompt. |
Alright, that sounds promising. Thanks for the docs, I'll take a look at this later. |
Hey, what's the status here? |
I fixed the bug I mentioned before and haven't run into any obvious issues since. |
Huh, that's odd. I see all tests passing on my M1 MacBook. |
Hey @y-mx-b - thanks for your patience on this, and for picking up this issue. We currently already have a facility to bypass all the screen clearing so that we won't have to do all the hard-work manually. We call is the |
No problem @imsnif, it's for my own benefit anyway.
|
Hey @y-mx-b - what's the status here? (no pressure, I just want to make sure I'm not blocking this through some misunderstanding) |
@imsnif I haven't really taken a look at |
I've pulled from the main repo on my fork and resolved merge conflicts. Formatting and testing has been done, and I've tested out the |
Hey @y-mx-b - I'm a little confused here - would you like to give this a go through the CLI client as mentioned, or? |
Forgot I had this PR. Closing because this feature was implemented in #3257. |
Currently, the screen will be cleared upon opening a session with the
--background
flag, but attaching the session and then detaching it will result everything but the attach and detach commands being shown again; the terminal essentially "forgets" about those two and then redraws the previously cleared screen.I'm not very familiar with ANSI escape codes or other terminal shenanigans, so I'd have to take a closer look at the
start_client_impl()
function in order to figure this out. If anyone could help me with this, that'd be great.