feat: add moving tab to other position

[devzbysiu]

This PR adds a possibility to move tab to other position (#1656)

Details:

• when we want to move the first tab to the left or the last tab to the right, the implementation wraps the tabs around (i.e.: moving first tab left will make this tab the last one, moving last tab right will make it the first one), so it switches the tab with the tab on the left/right as if the tabs are in circular buffer. This implementation allows changing tabs without the need to move all of the other tabs to different position. See the demo below.
• at this moment, the key bindings are set (in normal mode) to Alt + i for moving tab left and Alt + o for moving tab right (no particular reason for those bindings, I just picked something available and close to "hjkl row")
• major changes are:
  • changelog - changed separately after merge
  • added tip for this feature, here I also did small refactor of the tip files (moved the repeated strings! macro to the main module file and reused it in all tip files)
  • e2e tests, here I moved the steps definition to separate file so as not to clutter the cases file + snapshots
  • the feature itself (protobuf changes for new action and direction of move, handling the action) + unit tests

Demo:

• first I'm changing the tab name
• then showing the contents of all tabs
• then moving the tab around
• again showing contents of all tabs
• again some moving around

zellij-tabs-showcase.webm

Edit:
Demo of more complex scenarios:

zellij-tabs-complex-showcase.webm

[Andrew15-5]

I think a much visually impressive demo would be if each tab had multiple panes, this also would serve as a test/reassurance that this feature does work with multi-pane tabs. Or maybe some tabs have 1 pane, and some tabs have multiple panes.

[devzbysiu]

I think a much visually impressive demo would be if each tab had multiple panes, this also would serve as a test/reassurance that this feature does work with multi-pane tabs. Or maybe some tabs have 1 pane, and some tabs have multiple panes.

That's a good point. Added demo with more complex scenarios (multi-pane, single-pane, sync tabs).

[jaeheonji]

@devzbysiu

It really looks cool! I'll review it soon :)

Before that, I have one request. Please remove the CHANGELOG.md in changes. I will apply this after merging the PR seperatly.

[devzbysiu]

Hi @jaeheonji, thank you :)

I'll revert CHANGELOG.md asap. I'll also fix the tests (my bad, I focused on e2e and missed cargo xtask test 🤦‍♂️ )

[mmirus]

Thanks for working on this feature! I'm a new user and was missing it.

[jaeheonji]

I'm sorry. The review is late due to a personal issue. I haven't run the test yet, but I left a few comments. 😃

[jaeheonji]

Great! I think we are almost done.

Functionally I think I'm ready to merge now. But before that, I suggest some minor refactoring. Please take a look.

[devzbysiu]

@jaeheonji perfect. Thank you for the review 👍 . I'll take a look asap. Probably this weekend

[jaeheonji]

@devzbysiu Great :)

Actually, We plan to make a new release this weekend or next week. And we're hoping to include this feature in the next version. So, if you need any help, please let me know! then, I will update the refactoring part.

[jaeheonji]

LGTM. Really Good!

After CI is passed, I will merge as soon as possible.

[janos-r]

Omg after years finally!
Now I assume
#3080 and
#1656
can be closed if the feature gets released and works

[DanielAndreasen]

Speaking of, when can we expect this feature in a new release?

[giyany]

It's highly likely this release happens in April, but please don't come after me if it takes longer.

[youcefs21]

Hi, I know you said to not come after you if it takes longer, but it is almost end of may now, and I'd love an update on the progress

[DanielAndreasen]

It's in the latest release here: https://github.com/zellij-org/zellij/releases/tag/v0.40.1
And it works wonderfully! 🎉

[boblehest]

It's in the latest release here: https://github.com/zellij-org/zellij/releases/tag/v0.40.1 And it works wonderfully! 🎉

Is it described in the release notes? I can't see any mention of it.

[matteomanuelli]

It's in the latest release here: https://github.com/zellij-org/zellij/releases/tag/v0.40.1 And it works wonderfully! 🎉

I can't find we can't find the keybinding to move tab to another position

[Andrew15-5]

Same bindings as in the OP. You probably can get a new version of the config by renaming the existing config file. I think they should appear there.

[pdeva]

doing option-o/option-i doesnt work in macos...

[danieldk]

doing option-o/option-i doesnt work in macos...

Yeah, these key combinations are used by default on macOS for the slanted o/caret. I added these key bindings, so that I can do Shift left/right in tab mode to move around tabs:

keybinds {
        tab {
                bind "Shift Left" {
                        MoveTab "Left"
                }
                bind "Shift Right" {
                        MoveTab "Right"
                }
        }
}

[ailequal]

doing option-o/option-i doesnt work in macos...

Yeah, these key combinations are used by default on macOS for the slanted o/caret. I added these key bindings, so that I can do Shift left/right in tab mode to move around tabs:

keybinds {
        tab {
                bind "Shift Left" {
                        MoveTab "Left"
                }
                bind "Shift Right" {
                        MoveTab "Right"
                }
        }
}

Nice idea, love it! I improve it a little bit by also adding the "h" and "l" for moving with shift.

        bind "Shift Left" { MoveTab "Left"; }
        bind "Shift h" { MoveTab "Left"; }
        bind "Shift Right" { MoveTab "Right"; }
        bind "Shift l" { MoveTab "Right"; }