Update to Wasmtime 21.0.2 #3685
Conversation
|
Hey @bjorn3 - thanks for putting this together and following the issue. Maybe I'm missing something, but why are we only updating |
|
No reason really. I can change Cargo.toml too if you want. |
Let's do that. I think it'll be easier to follow the versions (at least for me). |
This fixes a race condition which causes occasional crashes and may enable a sandbox escape: <GHSA-7qmx-3fpx-r45m>
bjorn3
force-pushed
the
update_wasmtime
branch
from
b19899a
to
3c235b8
Compare
|
Done |
|
Perfect, thanks! |
| wasmtime = { version = "21.0.1", features = ["winch"] } # Keep in sync with the other wasmtime dep | ||
| wasmtime = { version = "21.0.2", features = ["winch"] } # Keep in sync with the other wasmtime dep |
There was a problem hiding this comment.
FYI: you can use workspace dependencies to write down the version and enabled features just one time and then reference that from multiple crates in the workspace.
For example:
There was a problem hiding this comment.
All wasmtime references are in this file. Also wasmtime and wasmtime-wasi need to be kept in sync, which workspace dependencies wouldn't help with. There are only three places in this file which need a version to be kept in sync anyway, so workspace dependencies would only complicate things IMHO. If you have a lot of uses that need fo be kept in sync, like is the case for the Wasmtime repo, then workspace dependencies do indeed make sense.
This fixes a race condition which causes occasional crashes and may enable a sandbox escape: <GHSA-7qmx-3fpx-r45m>
This fixes a race condition which causes occasional crashes and may enable a sandbox escape:
GHSA-7qmx-3fpx-r45m