Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Game Master module locality transfer fix timeout #487

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Remove Game Master module locality transfer fix timeout #487

merged 2 commits into from
Nov 20, 2020

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • title, with a very large amount of mods the module can take a long time to be unassigned when loading in initially (from testing, as much as 50 s)

@mharis001 mharis001 added the enhancement Improves an existing feature label Nov 16, 2020
@mharis001 mharis001 added this to the 1.10.0 milestone Nov 16, 2020
CreepPork
CreepPork reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other alternatives, by not relying on hard-coding the timeout?

@mharis001
Copy link
Member Author

Removing it altogether. Looking at it now, don't think it is needed.

@mharis001 mharis001 changed the title Increase Game Master module locality transfer fix timeout Remove Game Master module locality transfer fix timeout Nov 16, 2020
@mharis001 mharis001 added cleanup Removes bloat from code and removed enhancement Improves an existing feature labels Nov 16, 2020
@mharis001 mharis001 merged commit 979d8be into master Nov 20, 2020
@mharis001 mharis001 deleted the game-master-timeout branch November 20, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
cleanup Removes bloat from code
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mharis001 @CreepPork @neilzar