Fix attach offsets not being relative to the object's center #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
reviewed
Feb 24, 2022
|
Please remove the shortcut file as well. |
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
|
Done |
mharis001
approved these changes
Feb 24, 2022
|
Well spotted, but needs to be fixed for exported SQF as well: |
Kexanone
approved these changes
Feb 25, 2022
mharis001
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZEN/addons/common/functions/fnc_serializeObjects.sqf
Line 200 in 36ed484
At this line
worldToModel ASLtoAGL getPosASLis used to get the offset required for correct attachment of _x.The problem is, the resulting coordinate is not relative to the center of the _object, but it's base. (This may be more complicated if the object is tilted, but it's still not the center.) As a result, _x is displaced vertically.
I have tested the following method for every degree of rotation along the global X axis, from 0 to 359. It seems to be a lot more accurate without any special olympics tier of crutches to negate the error in the offset.
Related issue - #649