Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct canonical link for product_reviews_info page #6880

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lat9
Copy link
Contributor

@lat9 lat9 commented Dec 4, 2024

Fixes #6879

lat9 added 4 commits December 4, 2024 08:13
- Short array syntax
- No one-line conditionals
- Use 4-space indentation
- Use `str_ends_with` instead of `strstr`
- Use `!empty` instead of `isset && != ''`
- Move `products_all` into featured/specials/new array-check
- Use exactly-equal-to for specific current page checks
/**
* for all/new/special/featured listings:
*/
case (in_array($current_page, array(FILENAME_FEATURED_PRODUCTS, FILENAME_SPECIALS, FILENAME_PRODUCTS_NEW, FILENAME_PRODUCTS_ALL))):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to short array syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... because I missed it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect canonical link generated for product_reviews_info pages
2 participants