Add helper for generating periods on a date #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craiglittle
force-pushed
the
craig/day-periods
branch
from
6a032f7 to
0218a8e
Compare
This makes it much more straightforward to answer questions like "What was the first business time today?" or "What is the last business time today?". Having to call `to_a` in order to retrieve the last period on a date is a bit clunky, but I wanted the API to remain consistent with how `#before` and `#after` currently work. For the next major version, this will most likely be changed so all three methods resolve the lazy enumerator before returning.
This is a common question answered by business-hours gems, so we should show how to answer it.
craiglittle
force-pushed
the
craig/day-periods
branch
from
0218a8e to
6fcefab
Compare
alex-stone
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much more straightforward to answer common questions such as "What was the first business time today?" or "What is the last business time today?".
Further, more docs have been added to show how to calculate the previous or next business time from a given point in time, which is another common operation.
Closes #102.
@zendesk/darko
/cc @jakcharlton