Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Gemfile to gems.rb #121

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Rename Gemfile to gems.rb #121

merged 3 commits into from
Jun 12, 2018

Conversation

craiglittle
Copy link
Collaborator

@craiglittle craiglittle commented Jun 9, 2018

In v2.0, Bundler will move from Gemfile (and Gemfile.lock) to gems.rb (and gems.locked) as the default filenames for those files. In the meantime, the new filenames are already supported by recent releases of Bundler.

It's time to move boldly into the future.

Note that Bundler began acknowledging the new gem file format as of v1.8, hence the bundler version requirement bump.

See: https://depfu.com/blog/2017/09/06/gemfiles-new-clothes

In v2.0, Bundler will move from `Gemfile` (and `Gemfile.lock`) to
`gems.rb` (and `gems.locked`) as the default filenames for those files.
In the meantime, the new filenames are already supported by recent
releases of Bundler.

It's time to move boldly into the future.

Note that Bundler began acknowledging the new gem file format as of
v1.8, hence the `bundler` version requirement bump.

Reference: https://depfu.com/blog/2017/09/06/gemfiles-new-clothes
Now that RubyGems has been updated to be compatible with Ruby 2.5,
there's no longer any need for this command.

Reference:
* travis-ci/travis-ci#8978
@craiglittle craiglittle requested a review from a team June 9, 2018 04:59
The default RuboCop configuration has been changed to `[]` for both `%i`
and `%w`.

Reference
* https://github.com/brandonweiss/rubocop/commit/148ccf1e4c077b99a26b38ebbdad02a357a6d464
@craiglittle craiglittle force-pushed the craig/gemfile-rename branch from 9b2aebd to 7ea7c8d Compare June 9, 2018 15:20
@craiglittle craiglittle merged commit f0839fc into master Jun 12, 2018
@craiglittle craiglittle deleted the craig/gemfile-rename branch June 12, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants