Implement day-increment duration calculations #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now: ```ruby Biz::Schedule.new ``` returns a default schedule.
This brings in Clavius and sets up a number of convenience methods to make it easier to perform date-level calculations. Where possible, those methods are used to simplify methods.
craiglittle
force-pushed
the
craig/day-calcs
branch
3 times, most recently
from
8a8c663 to
cdfc461
Compare
Here's the syntax: ```ruby Biz.time(5, :days).after(Time.now) ``` Behavior notes: * The next business time at least 24 hours in the indicated direction will be returned. * If the equivalent time in the specified number of days isn't a business time, the *next* business time in the direction of the calculation (e.g. before or after) will be returned.
craiglittle
force-pushed
the
craig/day-calcs
branch
from
cdfc461 to
b288e6c
Compare
|
Tested this in my local, looks sweet! :D :D |
Directional `Periods` objects were made smarter by intuiting which the direction in which their timelines should run. For example: Before, you had to do this: ```ruby Biz.periods.after(Time.now).timeline.forward ``` Now, you can do do this: ```ruby Biz.periods.after(Time.now).timeline ``` However, users of the "dumb" versions should still be able to use the old interface without issue until we reach v2.0.
|
👍 💥 |
craiglittle
added a commit
that referenced
this pull request
Mar 20, 2015
Implement day-increment duration calculations
|
Released in |
|
woot thanks! 🙆♀️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus for this feature came from #14.
This implements day-increment calculations with a similar syntax to currently-supported units:
If the equivalent time in the specified number of days is in business hours, that time is returned. If that time is not in business hours, the next time in the calculation direction (e.g.
beforeorafter) will be returned.Refer to the original issue for a more thorough discussion of the behavior and reasoning.
@alex-stone
/cc @take