Remove unwarranted gem dependencies #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you intending to make similar changes to Clavius w.r.t. |
Yep, it's on the way! Stay tuned. |
craiglittle
force-pushed
the
craig/remove-dependencies
branch
2 times, most recently
from
dc1808d to
68149f8
Compare
RuboCop was getting a bit testy.
These will be used to perform deep equality assertions in specs without the use of the `equalizer` gem.
In the end, this gem really wasn't used for anything besides making the specs look a bit cleaner. Instead of having another runtime dependency, custom matchers were built out to provide the needed functionality. Inspired by: http://www.mikeperham.com/2016/02/09/kill-your-dependencies/
The benefit didn't outweigh the cost of an additional dependency.
The benefit didn't outweigh the cost of an additional dependency.
craiglittle
force-pushed
the
craig/remove-dependencies
branch
from
68149f8 to
028259b
Compare
@alex-stone @joshlam 💇 I've refactored the matchers a bit. This should be good to go. |
|
👍 |
craiglittle
added a commit
that referenced
this pull request
Feb 13, 2016
Remove unwarranted gem dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end, these gems didn't provide enough value to justify the cost of the additional dependencies.
Inspired by: http://www.mikeperham.com/2016/02/09/kill-your-dependencies/
@zendesk/darko