Clean up remaining post-extraction clutter #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
There's no longer any need to have a separate class to house this simple logic.
This method isn't used anywhere within the project and shouldn't be considered part of the public API.
In addition, define a public interface using class methods.
Since `Forwardable` is adding class methods and `Comparable is adding instance methods.
I swear this is the last time I'm going to tweak this. The primary reasoning here is that defining `<=>` on `Interval` will make the sorting that happens during configuration time slightly cleaner. At that point, there's no reason not to convert over `Holiday` and `TimeSegment` too, and be done with it once and for all.
This might come back in the future if cross-day configuration is explicitly supported.
I'm seeing the following the warning pop up occasionally when the build runs on Travis: ``` /home/travis/build/zendesk/biz/lib/biz/configuration.rb:7: warning: possible reference to past scope - raw ``` This should take care of it.
This silences the following deprecation warning which appeared when running the `benchmark/speed` script: ``` DEPRECATION WARNING: `Time.workday?(time)` is deprecated. Please use `time.workday?`. ```
These specs don't add much value and can confuse people about their purpose.
craiglittle
force-pushed
the
craig/slim-methods
branch
from
bff975a to
f8afe20
Compare
|
@joshlam 💇 |
|
|
craiglittle
added a commit
that referenced
this pull request
Mar 3, 2016
Clean up remaining post-extraction clutter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem was originally extracted from an internal project and continued to carry along some baggage from that time that no longer made sense in the context of a standalone library. This should mostly finish up the work to tidy up the remnants of that cruft as well as try out a couple more experimental ideas, such as being more aggressive about hiding access to constants meant for internal use.
Check out the individual commits for a more detailed breakdown of the work.
@alex-stone @joshlam