Reject negative scalars in for-duration calculations #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craiglittle
force-pushed
the
craig/zero-for-duration
branch
from
867c871 to
d09a3a6
Compare
|
After giving it more thought, I feel comfortable supporting the zero case whereby the first active moment in the chosen direction will be returned. I'll modify this PR to restrict the validation to rejecting negative values and follow up with another to support "zero" calculations. Stay tuned. |
craiglittle
force-pushed
the
craig/zero-for-duration
branch
2 times, most recently
from
12f63a7 to
8dc3737
Compare
craiglittle
changed the title
ForDuration scalar value
craiglittle
force-pushed
the
craig/zero-for-duration
branch
from
8dc3737 to
880888a
Compare
|
💇 I've modified this PR to focus on the new scalar validation (non-negative) and error streamlining. I'll be opening another to support zero-scalar calculations. |
Negative scalars are not something we want to explicitly support at this time, so we'll raise a helpful error message instead of randomly blowing up when someone tries to do it.
If we're primarily testing for the presence or absence of an exception being raised, let's do that consistently.
* Downcase first word (this is consistent with core Ruby) * Remove period at the end (also consistent with core Ruby) * Cut out unnecessary words
The generic `RuntimeError` was being raised when using `biz` before it is configured. Since we have a more descriptive configuration error, we should use it.
craiglittle
force-pushed
the
craig/zero-for-duration
branch
from
880888a to
99a971f
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative scalars are not something we want to explicitly support at this time, so we'll raise a helpful error message instead of randomly blowing up when someone tries to do it.
This also includes a bit of work to streamline and standardize exceptions.
Fixes #59.
@alex-stone @joshlam @kpandya91 @kbrainwave
/cc @mwean