Include breaks when intersecting schedules #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The involved munging is pretty much exclusively a configuration-level concern, so we should move it down to that level.
craiglittle
force-pushed
the
craig/break-intersection
branch
from
682446e to
64210a0
Compare
Breaks are treated similarly to holidays in that they are unioned together in the new schedule.
craiglittle
force-pushed
the
craig/break-intersection
branch
from
64210a0 to
c471b79
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks are treated similarly to holidays in that they are unioned together in the new schedule.
This PR also includes work to push the intersection logic down into the
Configurationobject.@zendesk/darko