Add on_break? schedule method
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| context 'when the time is not on a break' do |
There was a problem hiding this comment.
nit: This is fine, but I prefer when the time is not during a break for readability purposes.
There was a problem hiding this comment.
Yeah, on a does match up with the method name (on_break?) better, but it is also nice to provide richer/different descriptions in the docstrings to flesh out the intention. Will change!
|
👍, with or without suggested spec wording changes. |
Intervals and holidays already excluded their endpoint when determining if a time was within them. This makes it so time segments behave in the same way. It also refactors `Holiday` a bit to delegate to its underlying time segment for the operation.
Similar to `on_holiday?` with holidays, this method can be used to determine if a provided time occurs during a break.
This wording is a bit richer and provides more context with respect to the `on_*?` methods.
craiglittle
force-pushed
the
craig/on-break
branch
from
3487cf9 to
8f58c92
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
on_holiday?with holidays, this method can be used to determine if a provided time occurs during a break.@zendesk/darko