Skip to content

Commit

Permalink
fix: increase border contrast ratio for more theme elements
Browse files Browse the repository at this point in the history
Initially I added these changes to Help Center directly. It turns
out that doing so would amount to a breaking change for customers
who assume that these elements will remain the same color in their
custom themes. To err on the side of caution, I am adding them
to the Copenhagen theme instead.
  • Loading branch information
jbdietrich committed Dec 12, 2022
1 parent cbefd3b commit d32f6b3
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 2 deletions.
17 changes: 16 additions & 1 deletion style.css
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ ul {

.form-field .nesty-input {
border-radius: 4px;
border: 1px solid #87929D;
height: 40px;
line-height: 40px;
outline: none;
Expand All @@ -601,6 +602,10 @@ ul {
text-decoration: none;
}

.form-field .hc-multiselect-toggle {
border: 1px solid #87929D;
}

.form-field .hc-multiselect-toggle:focus {
outline: none;
border: 1px solid $brand_color;
Expand Down Expand Up @@ -5058,7 +5063,7 @@ html[dir="rtl"] .notification-left-aligned {

.dropdown-menu {
background: #fff;
border: 1px solid #d8d8d8;
border: 1px solid #87929D;
border-radius: 3px;
box-shadow: 0 1px 5px rgba(0, 0, 0, 0.1);
display: none;
Expand Down Expand Up @@ -5194,3 +5199,13 @@ html[dir="rtl"] .notification-left-aligned {
.content-tag-list li:last-child {
border: none;
}

/***** WYSIWYG Editor *****/
#hc-wysiwyg {
border: 1px solid #87929D;
}

/***** Upload Dropzone *****/
.upload-dropzone {
border: 1px solid #87929D;
}
2 changes: 1 addition & 1 deletion styles/_dropdowns.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

.dropdown-menu {
background: #fff;
border: 1px solid rgb(216, 216, 216);
border: 1px solid $high-contrast-border-color;
border-radius: 3px;
box-shadow: 0 1px 5px rgba(0, 0, 0 , .1);
display: none;
Expand Down
7 changes: 7 additions & 0 deletions styles/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
// Select box
.form-field .nesty-input {
border-radius: 4px;
border: 1px solid $high-contrast-border-color;
height: 40px;
line-height: 40px;
outline: none;
Expand All @@ -48,6 +49,12 @@
}
}

.form-field .hc-multiselect {
&-toggle {
border: 1px solid $high-contrast-border-color;
}
}

.form-field .hc-multiselect-toggle:focus {
outline: none;
border: 1px solid $brand_color;
Expand Down
4 changes: 4 additions & 0 deletions styles/_upload_dropzone.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/***** Upload Dropzone *****/
.upload-dropzone {
border: 1px solid $high-contrast-border-color;
}
4 changes: 4 additions & 0 deletions styles/_wysiwyg.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/***** WYSIWYG Editor *****/
#hc-wysiwyg {
border: 1px solid $high-contrast-border-color;
}
2 changes: 2 additions & 0 deletions styles/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@
@import "notifications";
@import "dropdowns";
@import "content-tags";
@import "wysiwyg";
@import "upload_dropzone";

0 comments on commit d32f6b3

Please sign in to comment.