fix: preload options to lookup field #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fetchedOptions = fetchedOptions.filter( | ||
| (option: FieldOption) => option.value !== selectedOption.value | ||
| ); | ||
| fetchedOptions = [selectedOption, ...fetchedOptions]; |
There was a problem hiding this comment.
Is this to guarantee that the selected option appears at the top?
There was a problem hiding this comment.
I think so 😬 just manually setting the order
There was a problem hiding this comment.
Is this the preferred experience for when an option is already selected?
I was going through the JIRA ticket and the slack thread but couldn't see it mentioned there.
There was a problem hiding this comment.
It is the same experience as in Lookup Field in Support and we want to make this fields almost the same.
luis-almeida
approved these changes
Sep 17, 2024
BrunoBFerreira
approved these changes
Sep 17, 2024
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira issue
When the combobox is focused and the input text is empty, the user will see a list of options retrieved from the Autocomplete API. The list is limited to 100 options maximum. The selected option is shown as the second option on the list after empty option.
The search icon is removed from the field.
Screenshots
Checklist