Support posix-exit-codes for child and in-process modes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73rhodes
force-pushed
the
dderidder/fix-exit-codes-pr-update
branch
5 times, most recently
from
33f2e8d to
e532714
Compare
73rhodes
changed the title
73rhodes
requested review from
a-brun,
jeansaad,
jugarrit,
rodgarciab,
SophiaRoland,
bhavikpatel-zd,
ayeoyeo,
serhiivas and
yaroslaviy
…rocess modes of running mocha
73rhodes
force-pushed
the
dderidder/fix-exit-codes-pr-update
branch
from
e532714 to
df38431
Compare
ayeoyeo
approved these changes
Aug 1, 2024
| if (os.platform() !== 'win32') { // SIGTERM is not supported on Windows | ||
| describe('when enabled, and with node options', function () { | ||
| var args = ['--no-warnings', '--posix-exit-codes']; | ||
| describe('when enabled', function () { |
There was a problem hiding this comment.
Does the test need coverage for exiting with success code 0?
serhiivas
approved these changes
Aug 1, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mocha has two ways of running: as a child process or in the main process. If there are any node command-line options (with or without mocha command line options) it will spawn a child process to run mocha and pass the node-specific options to that child process.
Reviewers of our PR to the upstream mocha repository requested that the
--posix-exit-codesoption should be supported in both modes of operation (mocha as a child process AND mocha in the main process). Originally I had it only working for mocha as a child process because that satisfies our use-case where we run mocha vianycwhich passes node-specific options.This PR also adds some additional unit tests to round out the coverage for these four scenarios:
Note that in ALL cases, when a fatal signal (ie. SIGABRT, SIGTERM) kills the mocha process, the exit code should now be [128 + numeric value of signal] in compliance with standard posix & bash command behaviour.