Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades sunshine-conversations-client to 9.6.0 #19

Merged
merged 1 commit into from
May 5, 2022
Merged

Upgrades sunshine-conversations-client to 9.6.0 #19

merged 1 commit into from
May 5, 2022

Conversation

BlackAF
Copy link
Contributor

@BlackAF BlackAF commented May 4, 2022

Description and reason for the change

This PR upgrades the sunshine-conversations-client package to 9.6.0 to fix a vulnerability found by Snyk.

Manual Tests:

  1. Start the server by running the index.js
  2. Start an ngrok tunnel to port 8000
  3. Setup a webhook on an existing app that targets ngrok
  4. Add a conversation:message trigger
  5. Send a message

Outcome: The webhook payload should show up for the server running at 8000

@BlackAF BlackAF requested a review from a team May 4, 2022 13:34
alexsincennes-z
alexsincennes-z approved these changes May 4, 2022
View reviewed changes
Copy link

@alexsincennes-z alexsincennes-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlackAF BlackAF merged commit e1d8999 into master May 5, 2022
@BlackAF BlackAF deleted the jephthia/SCE-1652 branch May 5, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsincennes-z alexsincennes-z alexsincennes-z approved these changes

@73rhodes 73rhodes 73rhodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlackAF @73rhodes @alexsincennes-z