Skip to content

Commit

Permalink
Bump lerna from 5.1.8 to 8.1.5 (palindromic upgrade)
Browse files Browse the repository at this point in the history
- Let's use the latest and greatest lerna
- Note that `lerna bootstrap` is replaced with `yarn install` post lerna v7 [1],
  and since this was leveraged in a postinstall script we can (and should) just
  remove, as otherwise now `yarn install` will recursively install, forever.
- Similarly, `lerna link` is no longer necessary post lerna v7, as package
  linking is done automagically as part of the `yarn install` process [2], so we
  should just delete any occurrences of this, such as in the link_dev script.

[1] https://lerna.js.org/docs/legacy-package-management#:~:text=Replace%20lerna%20bootstrap%20with%20npm%20install%20(or%20yarn/pnpm).%20If%20you%20are%20already%20performing%20your%20package%20manager%27s%20install%20command%20somewhere%20in%20your%20workflow%20before%20where%20you%20had%20previously%20called%20lerna%20bootstrap%2C%20then%20you%20can%20just%20delete%20it%20instead
[2] https://lerna.js.org/docs/legacy-package-management#:~:text=lerna%20link%20can%20just%20be%20removed%2C%20as%20the%20linking%20step%20is%20now%20handled%20by%20your%20package%20manager%20during%20npm%20install.
  • Loading branch information
token-cjg committed Jun 25, 2024
1 parent 3b164da commit 50d3850
Show file tree
Hide file tree
Showing 5 changed files with 1,584 additions and 1,753 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.0.0",
"form-data": "^4.0.0",
"lerna": "^5.1.8",
"lerna": "^8.1.5",
"lerna-changelog": "^2.2.0",
"mocha": "^10.0.0",
"nock": "^13.2.8",
Expand All @@ -46,7 +46,6 @@
],
"scripts": {
"audit:fix": "yarn-audit-fix",
"postinstall": "lerna bootstrap",
"dev": "ts-node ./packages/zcli/bin/run",
"git:check": "./scripts/git_check.sh",
"link:bin": "bash ./scripts/link_dev.sh",
Expand Down
2 changes: 1 addition & 1 deletion packages/zcli-apps/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"eslint": "^8.18.0",
"eslint-config-oclif": "^4.0.0",
"eslint-config-oclif-typescript": "^1.0.2",
"lerna": "^5.1.8",
"lerna": "^8.1.5",
"mocha": "^10.0.0",
"sinon": "^14.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/zcli-themes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"eslint": "^8.18.0",
"eslint-config-oclif": "^4.0.0",
"eslint-config-oclif-typescript": "^1.0.2",
"lerna": "^5.1.8",
"lerna": "^8.1.5",
"mocha": "^10.0.0",
"nock": "^13.2.8",
"sinon": "^14.0.0"
Expand Down
3 changes: 0 additions & 3 deletions scripts/link_dev.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ if [[ "$OSTYPE" == "cygwin" ]]; then
JAVASCRIPT_ENTRYPOINT_PATH="$(cygpath -wa "$JAVASCRIPT_ENTRYPOINT_PATH" | tr '\\' '/')"
fi

# link zcli-core & zcli-apps into ./packages/zcli/node_modules/@zendesk/
npx lerna link

# determine where we should install the stub to
YARN_GLOBAL_BIN_DIR="$(yarn global bin)"
TYPESCRIPT_ENTRYPOINT_PATH="$YARN_GLOBAL_BIN_DIR/zcli"
Expand Down
Loading

0 comments on commit 50d3850

Please sign in to comment.