Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module resolution #262

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: module resolution #262

merged 1 commit into from
Sep 5, 2024

Conversation

yoshdog
Copy link
Member

@yoshdog yoshdog commented Sep 5, 2024 •
edited by github-actions bot
Loading

Description

Fixes the following module resolution error:

./node_modules/.bin/zcli apps
(node:42933) [MODULE_NOT_FOUND] ModuleLoadError Plugin: @zendesk/zcli-apps: [MODULE_NOT_FOUND] require failed to load /Users/toanguyen/Code/zendesk/strategic-integrations-frontend/packages/deploy/node_modules/@zendesk/zcli-apps/dist/commands/apps/update.js: Cannot find module '@zendesk/zcli-core/src/lib/env'

3442b32 fix: module resolution

Detail

Checklist

  • 💂‍♂️ includes new unit and functional tests

@yoshdog yoshdog requested review from a team as code owners September 5, 2024 07:23
anushkafka
anushkafka approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@anushkafka anushkafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anushkafka anushkafka merged commit 12a08ce into master Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkafka anushkafka anushkafka approved these changes

@JeanMarcGoepfert JeanMarcGoepfert JeanMarcGoepfert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshdog @JeanMarcGoepfert @anushkafka