Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module resolution #262

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: module resolution #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/zcli-apps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"rimraf": "^3.0.2",
"semver": "^7.3.2",
"tslib": "^2.4.0",
"uuid": "^8.3.2"
"uuid": "^8.3.2",
"@zendesk/zcli-core": "^1.0.0-beta.49"
},
"devDependencies": {
"@oclif/test": "=2.1.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/zcli-apps/src/commands/apps/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { createAppPkg } from '../../lib/package'
import { Manifest, ZcliConfigFileContent } from '../../types'
import { validateAppPath } from '../../lib/appPath'
import { EnvVars } from '@zendesk/zcli-core/src/lib/env'
import { env } from '@zendesk/zcli-core'

export default class Update extends Command {
static description = 'updates an existing private app in the Zendesk products specified in the apps manifest file.'
Expand All @@ -20,7 +20,7 @@
static strict = false

getAppID (appConfig: ZcliConfigFileContent) {
const app_id = process.env[EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined)
const app_id = process.env[env.EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined)
if (!app_id) { throw new CLIError(chalk.red('App ID not found')) }
return app_id
}
Expand All @@ -30,7 +30,7 @@
const { job_id } = await deployApp('PUT', `api/v2/apps/${appID}`, uploadId)

try {
const { app_id }: any = await getUploadJobStatus(job_id, appPath)

Check warning on line 33 in packages/zcli-apps/src/commands/apps/update.ts

View workflow job for this annotation

GitHub Actions / build-and-check (ubuntu-latest, 18.x) 

Unexpected any. Specify a different type

Check warning on line 33 in packages/zcli-apps/src/commands/apps/update.ts

View workflow job for this annotation

GitHub Actions / build-and-check (macos-latest, 18.x) 

Unexpected any. Specify a different type

Check warning on line 33 in packages/zcli-apps/src/commands/apps/update.ts

View workflow job for this annotation

GitHub Actions / build-and-check (windows-latest, 18.x) 

Unexpected any. Specify a different type
CliUx.ux.action.stop('Deployed')
if (!manifest.requirementsOnly && manifest.location) {
Object.keys(manifest.location).forEach(async product => {
Expand Down
10 changes: 10 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1914,6 +1914,16 @@
resolved "https://registry.yarnpkg.com/@yarnpkg/lockfile/-/lockfile-1.1.0.tgz#e77a97fbd345b76d83245edcd17d393b1b41fb31"
integrity sha512-GpSwvyXOcOOlV70vbnzjj4fW5xW/FdUF6nQEt1ENy7m4ZCczi1+/buVUPAqmGfqznsORNFzUMjctTIp8a9tuCQ==

"@zendesk/zcli-core@*":
version "1.0.0-beta.49"
dependencies:
"@oclif/plugin-plugins" "=2.1.12"
axios "^1.7.5"
chalk "^4.1.2"
fs-extra "^10.1.0"
optionalDependencies:
keytar "^7.9.0"

JSONStream@^1.0.4:
version "1.3.5"
resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"
Expand Down
Loading