Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEG-742] Zcli package ignore #145

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

etanxing
Copy link
Contributor

@etanxing etanxing commented Nov 10, 2022

Reverts #144

ZCLI package ignore

Description

Added support for developers to specify files/folders to be ignored as part of the packaging process as requested in this PR.

Detail

Patterns following the gitignore specification included in a .zcliignore file in the root directory for the app will be excluded from packaging when any of the above commands are executed

Checklist

Includes new functional testing to ensure files specified are not included in packaging process.
Updated apps.md with information on .zcliignore feature

References

@etanxing etanxing changed the title Revert "Revert "Zcli package ignore"" [VEG-742] Revert "Revert "Zcli package ignore"" Nov 10, 2022
@etanxing etanxing changed the title [VEG-742] Revert "Revert "Zcli package ignore"" [VEG-742] Zcli package ignore Nov 10, 2022
@etanxing etanxing requested a review from a team November 10, 2022 03:34
@etanxing etanxing marked this pull request as ready for review November 10, 2022 03:35
Copy link
Member

@Frederick888 Frederick888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you. +1 on making the linter happy then I think it's good to go

Changed code so that instead of .find returning (undefined + "") when there is no filename starting with 'app' , find will either return a filename starting with 'app' or ''.
Copy link
Contributor

@anushkafka anushkafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@max1adam max1adam merged commit 5ce42b4 into master Nov 15, 2022
@max1adam max1adam deleted the revert-144-revert-142-ZCLI-package-ignore branch November 15, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants