[NO-JIRA] Bump typescript and @typescript-eslint #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
token-cjg
force-pushed
the
cgoddard/no-jira/bump-typescript-eslint
branch
3 times, most recently
from
96e39df
to
bfc6dc2
Compare
Let's bump our typescript tooling to something a bit more recent, there are also a few security vulnerabilities associated to earlier `@typescript-eslint` which are fixed with this change. Note: I've used a bit of a hammer to silence linting errors from `yarn lint`, there may be an argument to revisit linting in a future change to finesse things a tad. In short, - Bump `@typescript-eslint` from 5.30.0 to 7.14.1 - Bump typescript from 4.7.4 to 5.4.5. (I opted for the 5.4.x branch since 5.5.x seems a bit too recent and not mature yet) - We also need to bump eslint-config-oclif-typescript from 1.0.2 to 3.1.8, this is because it has a transitive dependency on an earlier version of `@typescript-eslint` (^4.31.2) [1] that is incompatible with typescript 5.x+ [2] - Squelch linting errors by switching off no-explicit-any in .eslintrc, and also silence unused var errors in test and application code. [1] https://github.com/oclif/eslint-config-oclif-typescript/blob/v1.0.2/package.json#L8-L9 [2] https://stackoverflow.com/a/77124060
token-cjg
force-pushed
the
cgoddard/no-jira/bump-typescript-eslint
branch
from
bfc6dc2
to
5892049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
@oclif/coreto a version that supports Typescript 5.x+ and alter application code to reflect the change in Oclif API@oclif/testto a version that supports the above application code changesDescription
bfc6dc2Bump typescript and@typescript-eslintLet's bump our typescript tooling to something a bit more recent, there are
also a few security vulnerabilities associated to earlier
@typescript-eslintwhich are fixed with this change.
In short,
@typescript-eslintfrom 5.30.0 to 7.14.15.5.x seems a bit too recent and not mature yet)
is because it has a transitive dependency on an earlier version of
@typescript-eslint(^4.31.2) [1] that is incompatible with typescript 5.x+ [2][1] https://github.com/oclif/eslint-config-oclif-typescript/blob/v1.0.2/package.json#L8-L9
[2] https://stackoverflow.com/a/77124060
Detail
Bump
typescriptand@typescript-eslintpackages to more recent variants to safeguard against code-rot + address security vulnerabilitiesChecklist